feat: add version deps command [modversion]

[Kubuxu]

• Tests

[Kubuxu]

For some reason, if I change Dependency to *Dependency here I get no output, no error and the encoder is not being run (tested with panic).

[Stebalien]

ipfs/go-ipfs-cmds#155

[Kubuxu]

@Stebalien this requires us to bump to Go1.12, is that ok?

[Stebalien]

ipfs/go-ipfs-cmds#155

[Stebalien]

foobar

[Kubuxu]

Seems like this error gets ignored. Interesting.

[Stebalien]

diff --git a/core/commands/version.go b/core/commands/version.go
index 9c5c666d0..c9632f799 100644
--- a/core/commands/version.go
+++ b/core/commands/version.go
@@ -118,9 +118,13 @@ Print out all dependencies and their versions.`,
 			}
 			return
 		}
-		res.Emit(toDependency(&info.Main))
+		if err := res.Emit(toDependency(&info.Main)); err != nil {
+			return err
+		}
 		for _, dep := range info.Deps {
-			res.Emit(toDependency(dep))
+			if err := res.Emit(toDependency(dep)); err != nil {
+				return err
+			}
 		}
 		return nil
 	},

[Stebalien]

@Kubuxu personally, I'm fine with a go 1.12 bump. Non-buggy go modules require that as well.

---

Other comment: needs test.

[Stebalien]

diff --git a/core/commands/version.go b/core/commands/version.go
index 9c5c666d0..c9632f799 100644
--- a/core/commands/version.go
+++ b/core/commands/version.go
@@ -118,9 +118,13 @@ Print out all dependencies and their versions.`,
 			}
 			return
 		}
-		res.Emit(toDependency(&info.Main))
+		if err := res.Emit(toDependency(&info.Main)); err != nil {
+			return err
+		}
 		for _, dep := range info.Deps {
-			res.Emit(toDependency(dep))
+			if err := res.Emit(toDependency(dep)); err != nil {
+				return err
+			}
 		}
 		return nil
 	},

[Stebalien]

@Kubuxu we'll also need to update the go version in CI.

[Kubuxu]

I know, just didn't have time to handle it today.

[Kubuxu]

This is ready.

[Kubuxu]

Wait with it, I've done something weird in sharness.

[Kubuxu]

I think it is done.

[Kubuxu]

It is ready.