Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document environment variables #6268

Merged
merged 2 commits into from
Apr 29, 2019
Merged

docs: document environment variables #6268

merged 2 commits into from
Apr 29, 2019

Conversation

Stebalien
Copy link
Member

fixes #5828

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
fixes #5828

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@ghost ghost assigned Stebalien Apr 26, 2019
@ghost ghost added the status/in-progress In progress label Apr 26, 2019
Copy link
Contributor

@michaelavila michaelavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Re environment vars: I did notice while looking around that we have a reference to the environment variable "IPFS_LOW_MEM" (./go-ipfs-flags/flags.go:11: if os.Getenv("IPFS_LOW_MEM") != "" {), but I don't actually see it being used anywhere. I mention it just in case. This list otherwise looks like the relevant stuff I'm finding.

Re mux: I can't comment on the stability, but I can take your word for it. For my own benefit, can you quickly elaborate on this experiment?

@Stebalien
Copy link
Member Author

Re environment vars: I did notice while looking around that we have a reference to the environment variable "IPFS_LOW_MEM" (./go-ipfs-flags/flags.go:11: if os.Getenv("IPFS_LOW_MEM") != "" {), but I don't actually see it being used anywhere. I mention it just in case. This list otherwise looks like the relevant stuff I'm finding.

It looks like it is used by bitswap.

Re mux: I can't comment on the stability, but I can take your word for it. For my own benefit, can you quickly elaborate on this experiment?

We have two stream multiplexers: yamux and mplex. We use yamux by default but neither js-libp2p nor rust-libp2p support yamux so we fallback on mplex.

@Stebalien
Copy link
Member Author

IPFS_LOW_MEM

Removed in ipfs/go-bitswap#115.

  1. This currently increases memory usage.
  2. We should just make this a configuration option.

@Stebalien Stebalien merged commit 92c88b0 into master Apr 29, 2019
@ghost ghost removed the status/in-progress In progress label Apr 29, 2019
@Stebalien Stebalien deleted the doc/environment branch April 29, 2019 16:33
@Stebalien Stebalien restored the doc/environment branch May 30, 2019 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document IPFS_PATH
3 participants