fix: windows friendly daemon help #6278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tweak the daemon --help output to use escaped double quotes instead of single quotes so the same command can be used on windows. fixes: #2034 License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
ghost
assigned 
|
I wasn't able to build and test this locally due to a error during ⨎ make build
go version go1.11.2 darwin/amd64
bin/check_go_version 1.12
go build -ldflags="-X "github.com/ipfs/go-ipfs".CurrentCommit=dd16b3ca1-dirty" -o "cmd/ipfs/ipfs" "github.com/ipfs/go-ipfs/cmd/ipfs"
go: downloading github.com/polydawn/refmt v0.0.0-20190221155625-df39d6c2d992
go: downloading golang.org/x/text v0.3.2
go: verifying github.com/polydawn/refmt@v0.0.0-20190221155625-df39d6c2d992: checksum mismatch
downloaded: h1:G16v6hoz+26YUMfvEvUkBKeJeIvsljFH2RRFY3MeXUA=
go.sum: h1:bzMe+2coZJYHnhGgVlcQKuRy4FSny4ds8dLQjw5P1XE=
make: *** [cmd/ipfs/ipfs] Error 1 |
You probably need go 1.12. There were some bugs in how go 1.11 handles modules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tweak the daemon --help output to use escaped double quotes instead
of single quotes so the same command can be used on windows.
fixes: #2034
License: MIT
Signed-off-by: Oli Evans oli@tableflip.io