ci: actually enable golangci-lint #6362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
ci/really-enable-lint
branch
from
dc0dd04
to
5b68c2b
Compare
Stebalien
commented
May 21, 2019
| @@ -599,8 +600,8 @@ Filters default to those specified under the "Swarm.AddrFilters" config key. | |||
| } | |||
|
|
|||
| var output []string | |||
| for _, f := range swrm.Filters.Filters() { | |||
| s, err := mafilter.ConvertIPNet(f) | |||
| for _, f := range swrm.Filters.FiltersForAction(mafilter.ActionDeny) { | |||
There was a problem hiding this comment.
Moving away from deprecated APIs.
Stebalien
commented
May 21, 2019
| @@ -14,7 +14,7 @@ import ( | |||
| $shortpkg "$pkg" | |||
| ) | |||
|
|
|||
| var Plugins = $shortpkg.Plugins | |||
| var Plugins = $shortpkg.Plugins //nolint | |||
There was a problem hiding this comment.
Don't lint because this is "unused".
magik6k
approved these changes
May 21, 2019
namesys/resolve/pathresolver_test.go
Outdated
| @@ -16,17 +16,17 @@ func TestResolveNoComponents(t *testing.T) { | |||
| } | |||
|
|
|||
| _, err = resolve.Resolve(n.Context(), n.Namesys, n.Resolver, path.Path("/ipns/")) | |||
| if err != path.ErrNoComponents { | |||
| t.Fatal("Should error with no components (/ipns/).", err) | |||
| if err == nil { | |||
There was a problem hiding this comment.
We probably want to check more than 'there was an error'
michaelavila
approved these changes
May 21, 2019
Stebalien
force-pushed
the
ci/really-enable-lint
branch
from
5b68c2b
to
c39ad0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fixes #6320 (golangci-lint will fail if something doesn't compile)