Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building non-amd64 Docker images #6854

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

cap10morgan
Copy link
Contributor

These changes allowed me to build arm Docker images to run on my Raspberry Pi. I used the new docker buildx feature to cross-build them. Let me know how else you'd like that documented / integrated into this repo.

The images I built are hosted here: https://hub.docker.com/repository/docker/cryptorado/go-ipfs

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

And yes, documentation (in the docker section of the readme) would be most welcome.

@Stebalien Stebalien merged commit 7969dbf into ipfs:master Jan 30, 2020
@cap10morgan
Copy link
Contributor Author

@Stebalien Thanks for merging! Since this is about building multi-arch images (rather than using the pre-built images which is what that section of the readme is about), is there some way I can help get the official images building arm64 and armv7 variants?

@Stebalien
Copy link
Member

We just let docker hub auto-build from github. I'm not sure how to convince docker hub to build cross-platform.

@mburns
Copy link
Contributor

mburns commented Jan 30, 2020

https://hub.docker.com/r/ckulka/multi-arch-example seems like a reasonable guide.

I don't have permission to view/make changes on the Hub side, fwiw, but this seems straightforward if there is interest in making it happen.

@Stebalien
Copy link
Member

Nice!

Github version: https://github.com/ckulka/docker-multi-arch-example

I wonder if there's any way to avoid duplicating the docker file.


@mburns I've given you the correct permissions, I think. Go for it (when you have time).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants