Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/macos sharness fixes #6988

Merged
merged 3 commits into from
Mar 12, 2020
Merged

Chore/macos sharness fixes #6988

merged 3 commits into from
Mar 12, 2020

Conversation

ribasushi
Copy link
Contributor

No description provided.

A dependency of ours now requires 1.14, let's be more explicit ourselves

../../go/pkg/mod/github.com/lucas-clemente/quic-go@v0.15.2/interface.go:54:2: duplicate method StreamID
../../go/pkg/mod/github.com/lucas-clemente/quic-go@v0.15.2/stream.go:44:2: duplicate method StreamID
note: module requires Go 1.14
Under high paralellism we would be regenerating the plugin source
while doing the initial `go fmt` read.

Instead simply exclude the generated file.
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@Stebalien Stebalien merged commit fe83c19 into master Mar 12, 2020
@hacdias hacdias deleted the chore/macos_sharness_fixes branch May 9, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants