Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd service enhancements + run as system user #7259

Merged

Conversation

RubenKelevra
Copy link
Contributor

@RubenKelevra RubenKelevra commented Apr 30, 2020

enable restart on crash and run as system user 'ipfs'

add some optional parameters with short help texts

@auto-comment
Copy link

auto-comment bot commented Apr 30, 2020

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This unit is a minimal and conservative starting point, let's avoid adding too much.

misc/systemd/ipfs.service Show resolved Hide resolved
misc/systemd/ipfs.service Outdated Show resolved Hide resolved
misc/systemd/ipfs.service Outdated Show resolved Hide resolved
misc/systemd/ipfs@.service Outdated Show resolved Hide resolved
misc/systemd/ipfs.service Show resolved Hide resolved
@RubenKelevra RubenKelevra force-pushed the feat/systemd-service-enhancements branch from b2d3c82 to 9412493 Compare April 30, 2020 18:57
@RubenKelevra RubenKelevra changed the title systemd service enhancements + user service systemd service enhancements + run as system user Apr 30, 2020
add some optional paramters with short help texts
add sysuser.conf
@RubenKelevra RubenKelevra force-pushed the feat/systemd-service-enhancements branch from 9412493 to dfb52fb Compare April 30, 2020 20:01
@RubenKelevra
Copy link
Contributor Author

This unit is a minimal and conservative starting point, let's avoid adding too much.

Ready for a new review :)

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Stebalien Stebalien merged commit 96169ad into ipfs:master Apr 30, 2020
@RubenKelevra RubenKelevra deleted the feat/systemd-service-enhancements branch May 1, 2020 03:06
@Stebalien Stebalien mentioned this pull request May 26, 2020
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants