Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not create a new (unused) peerID when initializing from config #7730

Merged
merged 1 commit into from
Nov 24, 2020
Merged

fix: do not create a new (unused) peerID when initializing from config #7730

merged 1 commit into from
Nov 24, 2020

Conversation

aschmahmann
Copy link
Contributor

No description provided.

petar
petar approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@petar petar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

straiforos
straiforos reviewed Oct 29, 2020
View reviewed changes
Copy link

@straiforos straiforos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work seems like a logical change, the daemon seems like an odd place for it when init is required.

@aschmahmann aschmahmann merged commit 776e03c into master Nov 24, 2020
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
Closed
73 tasks
@gammazero gammazero deleted the fix/init-with-config branch April 14, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straiforos straiforos straiforos left review comments

@petar petar petar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aschmahmann @petar @straiforos