Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multibase transcode command #8403

Merged
merged 2 commits into from
Sep 21, 2021
Merged

Conversation

andey-robins
Copy link
Contributor

In order to more easily facilitate the conversion between multibase formats, include a transcode command to avoid multibase decode | multibase encode

Closes #8336

Related to PR #8180, adds in some of the functionality discussed as desired, but not required for that PR.

(This is my first PR, and I've read through the Contribution Guidelines for the go-ipfs projects and the ipfs/community guidelines as well, but if I've missed something please just let me know!)

In order to more easily facilitate the conversion
between multibase formats, include a transcode command
to avoid `multibase decode | multibase encode`
@welcome

This comment has been minimized.

@lidel lidel self-requested a review September 3, 2021 15:37
@BigLep BigLep added the P3 Low: Not priority right now label Sep 10, 2021
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @andey-robins! LGTM. ❤️

@aschmahmann ready for your final review and merge

Discussed during go-ipfs sync today – should be safe to include in 0.10.0-rc2, merging.

@BigLep BigLep changed the title Add a transcoder command to multibase Add a transcode command to multibase Sep 21, 2021
@BigLep BigLep added this to the go-ipfs 0.10 milestone Sep 21, 2021
@lidel lidel changed the title Add a transcode command to multibase feat: multibase transcode command Sep 21, 2021
@lidel lidel merged commit c891109 into ipfs:master Sep 21, 2021
aschmahmann pushed a commit that referenced this pull request Sep 27, 2021
* Add a transcoder command to multibase

In order to more easily facilitate the conversion
between multibase formats, include a transcode command
to avoid `multibase decode | multibase encode`

* Example code needed go mod tidy

Co-authored-by: gammazero <gammazero@users.noreply.github.com>
(cherry picked from commit c891109)
aschmahmann pushed a commit that referenced this pull request Sep 27, 2021
* Add a transcoder command to multibase

In order to more easily facilitate the conversion
between multibase formats, include a transcode command
to avoid `multibase decode | multibase encode`

* Example code needed go mod tidy

Co-authored-by: gammazero <gammazero@users.noreply.github.com>
(cherry picked from commit c891109)
aschmahmann pushed a commit that referenced this pull request Sep 27, 2021
* Add a transcoder command to multibase

In order to more easily facilitate the conversion
between multibase formats, include a transcode command
to avoid `multibase decode | multibase encode`

* Example code needed go mod tidy

Co-authored-by: gammazero <gammazero@users.noreply.github.com>
(cherry picked from commit c891109)
@aschmahmann aschmahmann mentioned this pull request Sep 30, 2021
62 tasks
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Low: Not priority right now
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add "ipfs multibase transcode" command
4 participants