-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: go-libp2p 0.16 and autosharding and go-datastore to take contexts #8563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
making deprecation notice match the go-ipfs-config key
Applies changes from ipfs/go-ipfs-config@c46fe1b
Clarified docs based on #8522 (comment) License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
this moves relay "user" flag before the "service" to align better with new docs in effort to limit the number of people that mistake the two. License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
This switches to config that supports setting and reading Internal.Libp2pForceReachability OptionalString flag License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
does not cause issue locally, let's see how behaves on CI
This is for testing the libp2p release, since the context changes are not plumbed all the way through.
- applies fix from go-ipfs-config which removes null when default - escapes JSON string when passed in sharness script
* test: add tests for automatic sharding and unsharding * refactor: changed some naming in the sharding sharness tests to make more sense Co-authored-by: Adin Schmahmann <adin.schmahmann@gmail.com>
This is for testing the libp2p release, since the context changes are not plumbed all the way through.
aschmahmann
changed the title
Feat/update datastore
update go-datastore to take contexts
Nov 22, 2021
…8559) * exit when Swarm.EnableRelayHop is set * chore: go-ipfs-config v0.18.0 Co-authored-by: Marcin Rataj <lidel@lidel.org>
lidel
changed the title
update go-datastore to take contexts
feat: go-libp2p 0.16 and autosharding and go-datastore to take contexts
Nov 23, 2021
This ensures existing users of global sharding experiment get notified that the flag no longer works + that autosharding happens automatically. For people who NEED to keep the old behavior (eg. have no time to migrate today) there is a note about restoring it with `UnixFSShardingSizeThreshold`.
This was referenced Nov 23, 2021
aschmahmann
force-pushed
the
feat/update-datastore
branch
from
November 24, 2021 02:38
ac61a02
to
cb4cf5c
Compare
lidel
reviewed
Nov 26, 2021
aschmahmann
commented
Nov 29, 2021
github.com/ipfs/go-fs-lock v0.0.7 | ||
github.com/ipfs/go-graphsync v0.8.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: use released go-graphsync
Co-authored-by: Marcin Rataj <lidel@lidel.org>
We're going to squash the history here since it's reasonably long and pretty messy. |
lidel
approved these changes
Nov 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👀 💧
This was referenced Nov 29, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ties together #8522 and #8527 since they both rely on updates to go-datastore and therefore need to be merged together.
Interop tests: ipfs/interop#400