Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cmds): ipfs id: support --offline option #8626

Merged
merged 2 commits into from
Feb 10, 2022
Merged

feat(cmds): ipfs id: support --offline option #8626

merged 2 commits into from
Feb 10, 2022

Conversation

schomatis
Copy link
Contributor

@schomatis schomatis commented Dec 28, 2021 •
edited
Loading

Closes #8481.

@schomatis schomatis requested a review from lidel December 28, 2021 14:42
@schomatis schomatis self-assigned this Dec 28, 2021
schomatis
schomatis commented Dec 31, 2021
View reviewed changes
core/commands/id.go Outdated Show resolved Hide resolved
lidel
lidel requested changes Jan 13, 2022
View reviewed changes
core/commands/id.go Outdated Show resolved Hide resolved
@schomatis schomatis force-pushed the schomatis/feat/cmds/id/offline-option branch from b30518e to 11d7450 Compare January 14, 2022 14:25
@schomatis schomatis marked this pull request as ready for review January 14, 2022 14:26
@schomatis schomatis requested a review from lidel January 14, 2022 14:26
@lidel lidel force-pushed the schomatis/feat/cmds/id/offline-option branch from 11d7450 to 27432e6 Compare January 19, 2022 15:18
@lidel lidel changed the title feat(cmds): ipfs id: add offline option feat(cmds): ipfs id: support --offline option Jan 19, 2022
lidel
lidel approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

(rebase & tweaked helptext a bit, so it's easier to reason why someone would run ipfs id in offline mode)

@lidel lidel added the status/ready Ready to be worked label Jan 25, 2022
@lidel lidel merged commit a494f48 into master Feb 10, 2022
@lidel lidel deleted the schomatis/feat/cmds/id/offline-option branch February 10, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

Assignees

@schomatis schomatis

Labels
status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ipfs id --offline <peerid> does not work offline
2 participants
@schomatis @lidel