fix: allow ipfs-companion browser extension to access RPC API #8690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc/ @lidel |
meandavejustice
force-pushed
the
feat/add-companion-id-to-allowed-origins
branch
from
a565133
to
7978e05
Compare
- fixes ipfs#8689 - Adds the chrome-extension ids for ipfs-companion and ipfs-companion-beta to the allowed origins list, this allows us to accesss ipfs api from a manifest v3 extension. - added tests in t0401-api-browser-security.sh
meandavejustice
force-pushed
the
feat/add-companion-id-to-allowed-origins
branch
from
7978e05
to
c48b612
Compare
lidel
changed the title
lidel
approved these changes
Mar 16, 2022
There was a problem hiding this comment.
LGTM. I'll add tests to confirm this still works when one defined own CORS safelist.
This ensures we don't break common use cases:
- users of ipfs-desktop: it adds own CORS entries
- users of webui.ipfs.io (bleeding edge version) who manually added it to CORS safelist
- webui developers, who safelist localhost Origins for local dev
Companion extension should be able to access RPC API even when custom Access-Control-Allow-Origin is set
lidel
force-pushed
the
feat/add-companion-id-to-allowed-origins
branch
from
35ac0b2
to
994ef08
Compare
9 tasks
13 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipfs-companion-beta to the allowed origins list, this
allows us to accesss ipfs api from a manifest v3 extension.