Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cmds/keystore): do not allow to import keys we don't generate #8733

Merged
merged 1 commit into from
Feb 18, 2022
Merged

fix(cmds/keystore): do not allow to import keys we don't generate #8733

merged 1 commit into from
Feb 18, 2022

Conversation

schomatis
Copy link
Contributor

No description provided.

@schomatis schomatis requested a review from lidel February 11, 2022 15:14
@schomatis schomatis self-assigned this Feb 11, 2022
lidel
lidel approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This compliments #8616 nicely (protects against folks importing PEMs with unsupported key types)

@lidel lidel merged commit 3ea5631 into master Feb 18, 2022
@lidel lidel deleted the schomatis/cmds/keystore/restrict-key-import branch February 18, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschmahmann aschmahmann aschmahmann approved these changes

@lidel lidel lidel approved these changes

Assignees

@schomatis schomatis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schomatis @lidel @aschmahmann