Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gw): missing return if dir fails to finalize #8806

Merged
merged 1 commit into from
Apr 8, 2022
Merged

fix(gw): missing return if dir fails to finalize #8806

merged 1 commit into from
Apr 8, 2022

Conversation

makew0rld
Copy link
Contributor

Just fixing a small bug I noticed when working on a project for Agregore Mobile, something I discussed with @lidel.

@welcome

This comment was marked as resolved.

Sign in to view
@lidel lidel changed the title Add missing return if dir fails to finalize fix(gw) missing return if dir fails to finalize Mar 21, 2022
@lidel lidel changed the title fix(gw) missing return if dir fails to finalize fix(gw): missing return if dir fails to finalize Mar 21, 2022
@lidel lidel self-assigned this Mar 21, 2022
lidel
lidel approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but not sure why the go-ipfs-http-client test fails consistently.

Let's wait with merge until CI can be made green.

@lidel lidel added the status/blocked Unable to be worked further until needs are met label Mar 21, 2022
@makew0rld
Copy link
Contributor Author

Thanks. Any idea if the failure due to my code, or if there's some CI issue? The failing tests seem unrelated to these changes.

@BigLep BigLep assigned makew0rld and unassigned lidel Mar 23, 2022
@BigLep BigLep added this to the Best Effort Track milestone Mar 23, 2022
@BigLep
Copy link
Contributor

BigLep commented Mar 25, 2022

You're right. This is a go-ipfs CI issue we're actively getting fixed. We'll merge after.

@BigLep BigLep mentioned this pull request Mar 29, 2022
Closed
@lidel lidel added the topic/gateway Topic gateway label Apr 5, 2022
@lidel lidel modified the milestones: Best Effort Track, go-ipfs 0.13 Apr 5, 2022
@lidel lidel removed the status/blocked Unable to be worked further until needs are met label Apr 6, 2022
@lidel
Copy link
Member

lidel commented Apr 6, 2022

Rebased on master, let's wait for CI.

@lidel lidel merged commit 52bf133 into ipfs:master Apr 8, 2022
xrazis pushed a commit to xrazis/kubo that referenced this pull request Apr 14, 2022
@makew0rld @xrazis
fix(gw): missing return if dir fails to finalize (ipfs#8806)
b204bb0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

Assignees
No one assigned
Labels
topic/gateway Topic gateway
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
go-ipfs 0.13
Development

Successfully merging this pull request may close these issues.
3 participants
@makew0rld @BigLep @lidel