Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracing): context plumbing in gateway handlers #8871

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

guseggert
Copy link
Contributor

This ensures that child contexts are passed around between the
handlers so that traces show the call hierarchy correctly.

@guseggert guseggert requested a review from lidel April 11, 2022 19:10
@guseggert guseggert force-pushed the fix/gateway-handler-tracing-contexts branch from a72b5ad to 49942c4 Compare April 11, 2022 19:13
This ensures that child contexts are passed around between the
handlers so that traces show the call hierarchy correctly.
@guseggert guseggert force-pushed the fix/gateway-handler-tracing-contexts branch from 49942c4 to 0b2ebbe Compare April 11, 2022 19:13
@lidel lidel changed the title fix: fix context plumbing in gateway handlers fix: context plumbing in gateway handlers Apr 11, 2022
@lidel lidel changed the title fix: context plumbing in gateway handlers fix(tracing): context plumbing in gateway handlers Apr 11, 2022
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lidel lidel merged commit 9bd346e into master Apr 11, 2022
@lidel lidel deleted the fix/gateway-handler-tracing-contexts branch April 11, 2022 21:09
xrazis pushed a commit to xrazis/kubo that referenced this pull request Apr 14, 2022
This ensures that child contexts are passed around between
the handlers so that traces show the call hierarchy correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants