-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update test/dependencies to match actual go-ipfs dependencies. #8928
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
test/dependencies/go.mod
Outdated
@@ -1,30 +1,244 @@ | |||
module github.com/ipfs/go-ipfs/test/dependencies | |||
|
|||
go 1.13 | |||
go 1.17 | |||
|
|||
require ( | |||
github.com/Kubuxu/gocovmerge v0.0.0-20161216165753-7ecaa51963cd | |||
github.com/golangci/golangci-lint v1.26.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's update golangci-lint as well
b48b816
to
13c2fa3
Compare
13c2fa3
to
e422799
Compare
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Done to avoid dependency inconsistency problems. Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
e422799
to
0764b9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks 🙏
This PR intends to match
go-ipfs
dependencies withtest/dependencies
dependencies.go get github.com/ipfs/go-ipfs@latest && go mod edit -droprequire github.com/ipfs/go-ipfs && go mod tidy
Still work to do. I don't have enough knowledge to know if we can safely delete
storeutil.StorerForBlockstore(bs)
fromgraphsync-get.go
Closes #8310
Signed-off-by: Antonio Navarro Perez antnavper@gmail.com