ci: add more golang strictness checks #8931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
force-pushed
the
ci/add-more-checks
branch
from
679b8b1
to
1abd493
Compare
ajnavarro
suggested changes
May 3, 2022
| fi | ||
| git diff --exit-code -- go.sum go.mod | ||
| - name: gofmt | ||
| if: ${{ success() || failure() }} # run this step even if the previous one failed |
There was a problem hiding this comment.
nit: you can use if: always() here.
| exit 1 | ||
| fi | ||
| - name: go vet | ||
| if: ${{ success() || failure() }} # run this step even if the previous one failed |
There was a problem hiding this comment.
nit: the same, you can use if: always() here.
ajnavarro
approved these changes
May 3, 2022
aschmahmann
force-pushed
the
ci/add-more-checks
branch
from
1abd493
to
1f37a14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.