fix: add dag walker for json codec #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the json codec is bundled with multiformats we should add a dag walker for it to allow pinning json blocks. Fixes #246
juliangruber
approved these changes
Aug 26, 2023
whizzzkid
approved these changes
Aug 26, 2023
| expect(pins).to.have.nested.property('[0].metadata').that.eql({}) | ||
|
|
||
| await expect(helia.pins.isPinned(cid1)).to.eventually.be.true() | ||
| await expect(helia.pins.isPinned(cid2)).to.eventually.be.true() |
There was a problem hiding this comment.
These tests are the same except the data being encoded and pinned. This can be refactored to run as a loop over different encoded values. I feel it makes the test more readable as it would be immediately clear what exactly the test is testing.
Optional.
This was referenced Jan 8, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the json codec is bundled with multiformats we should add a dag walker for it to allow pinning json blocks.
Fixes #246