Skip to content
This repository has been archived by the owner on Jun 19, 2023. It is now read-only.

Remove hidden file handling #17

Closed
Stebalien opened this issue Mar 7, 2019 · 5 comments
Closed

Remove hidden file handling #17

Stebalien opened this issue Mar 7, 2019 · 5 comments
Assignees
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@Stebalien
Copy link
Member

We should be able to handle this at the cmds (and maybe files) layer and filter hidden files out before they ever reach the CoreAPI. Does this make sense?

@Stebalien Stebalien added the kind/enhancement A net-new feature or improvement to an existing feature label Mar 7, 2019
@magik6k
Copy link
Member

magik6k commented Mar 8, 2019

It should be possible to implement this as a proxy files layer, that would make things much nicer in the adder code.

(also, with the current way it works, we send hidden files to the daemon, just so they get dropped there)

@Stebalien
Copy link
Member Author

Are you sure we send hidden files? It looks like the commands library is dropping them, as far as I can tell.

@magik6k
Copy link
Member

magik6k commented Mar 11, 2019

It looks like the commands library is dropping them

Right, we do that (with a small bug - ipfs/go-ipfs-files#11), and it makes things much simpler if we don't care about handling hidden in http api - I removed all hidden file handling from CoreAPI and the command in
ipfs/kubo#6019, and it still just works.

(If we want to remove hidden handling from http api, we'll probably need to adjust what js-ipfs does)

@Stebalien
Copy link
Member Author

js-ipfs does it client-side as well.

Stebalien referenced this issue in ipfs/kubo Apr 6, 2019
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@magik6k
Copy link
Member

magik6k commented May 3, 2019

ipfs/kubo#6019

@magik6k magik6k closed this as completed May 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants