This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
fix: stats not implemented on jsipfs #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@diasdavid could you check if this (only returning when we're using promises) is right? |
|
@diasdavid just confirmed and it works. |
daviddias
suggested changes
Jan 25, 2018
src/stats.js
Outdated
| return | ||
| } | ||
|
|
||
| ipfs.stats.bw().then((res) => { |
There was a problem hiding this comment.
@hacdias you should add a return here. Otherwise the test will pass before the call happens.
There was a problem hiding this comment.
OOPS! Sorry. fixed!
|
@diasdavid fixed 😄 |
daviddias
suggested changes
Jan 25, 2018
src/stats.js
Outdated
| @@ -101,7 +101,7 @@ module.exports = (common) => { | |||
| return | |||
| } | |||
|
|
|||
| ipfs.stats.bw().then((res) => { | |||
| return ipfs.stats.bw().then((res) => { | |||
There was a problem hiding this comment.
@hacdias have you checked if this is done in all the tests?
There was a problem hiding this comment.
Yes, on all promises tests
daviddias
approved these changes
Jan 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref.: ipfs/js-ipfs#1189