This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
fix: fix broken stats test #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
hacdias
approved these changes
Mar 13, 2018
|
@MichaelMure See this PR for future reference. I also wasn't aware that passing in the |
9 tasks
Tests broke due to c4934ca [1]. If promises are used, you needn't pass `done` as parameter of the callback in. [1]: c4934ca#diff-0a6449ecfa8b9e3d807f53dde24eca71R66
daviddias
approved these changes
Mar 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One test broke due to c4934ca 1.
If promises are used, you needn't pass
doneas parameter ofthe callback in.