This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
feat: better badge #246
Merged
feat: better badge #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alanshaw
commented
Mar 27, 2018
alanshaw
commented
- Aligns text better within box
- Adds 2x resolution PNG version
- Adds vector version
- Uses vector version on README
- Adds badge markdown code to README
ghost
assigned 
|
The SVG version seems ~~~misaligned~~~ wrong for me on Firefox: |
|
oh no, where are your fonts? |
|
Maybe it needs a fallback to Helvetica |
|
Better now @victorbjelkholm? |
|
@alanshaw aren't both Helvetica and Helvetica Neiu osx-only fonts? Unless you have a license of course. Should probably just fallback to
|
|
It look ok in this window:
|
daviddias
approved these changes
Apr 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.