Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

feat: add onlyHash option to files.add #259

Merged
merged 1 commit into from
Apr 30, 2018
Merged

feat: add onlyHash option to files.add #259

merged 1 commit into from
Apr 30, 2018

Conversation

hacdias
Copy link
Contributor

@hacdias hacdias commented Apr 30, 2018

No description provided.

@ghost ghost assigned hacdias Apr 30, 2018
@ghost ghost added the in progress label Apr 30, 2018
@hacdias hacdias requested a review from daviddias April 30, 2018 07:19
@hacdias
Copy link
Contributor Author

hacdias commented Apr 30, 2018

@diasdavid just a simple addition here.

@daviddias
Copy link
Contributor

@hacdias is there a test + has this been tested against js-ipfs and js-ipfs-api?

@hacdias
Copy link
Contributor Author

hacdias commented Apr 30, 2018

@diasdavid both have their implementations and their tests (js-ipfs-api, js-ipfs), but I can add one here.

@hacdias
Copy link
Contributor Author

hacdias commented Apr 30, 2018

image

image

Working @diasdavid.

@daviddias
Copy link
Contributor

Thank you @hacdias ❤️

@daviddias daviddias merged commit 63179b9 into master Apr 30, 2018
@daviddias daviddias deleted the only-hash branch April 30, 2018 08:22
@ghost ghost removed the in progress label Apr 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants