Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

fix: allow only by object #407

Merged
merged 2 commits into from
Dec 14, 2018
Merged

fix: allow only by object #407

merged 2 commits into from
Dec 14, 2018

Conversation

alanshaw
Copy link
Contributor

@alanshaw alanshaw commented Dec 5, 2018

The only option will now accept an object for onlying a specific test.

Previously you could only do this to only run a specific test:

{
  only: ['should test a thing']
}

Now you can do this:

{
  only: [{
    name: 'should test a thing',
    reason: 'because development' // optional!
  }]
}

License: MIT
Signed-off-by: Alan Shaw alan.shaw@protocol.ai

The only option will now accept an object for onlying a specific test.

Previously you could only do this to only run a specific test:

```js
{
  only: ['should test a thing']
}
```

Now you can do this:

```js
{
  only: [{
    name: 'should test a thing',
    reason: 'because development' // optional!
  }]
}
```

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@ghost ghost assigned alanshaw Dec 5, 2018
@ghost ghost added the in progress label Dec 5, 2018
alanshaw pushed a commit to ipfs-inactive/js-ipfs-http-client that referenced this pull request Dec 5, 2018
Not being applied because ipfs-inactive/interface-js-ipfs-core#407

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@achingbrain
Copy link
Collaborator

Is this in a README somewhere? I find myself rummaging around in my memory/the codebase a lot for this sort of thing.

@alanshaw
Copy link
Contributor Author

alanshaw commented Dec 5, 2018

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@alanshaw
Copy link
Contributor Author

Assuming this is ok....am merge. Shout if this is not what you wanted!

@alanshaw alanshaw merged commit 1766ef4 into master Dec 14, 2018
@alanshaw alanshaw deleted the fix/only-by-object branch December 14, 2018 18:14
@ghost ghost removed the in progress label Dec 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants