Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

feat: add support new ctl #541

Merged
merged 12 commits into from
Dec 11, 2019
Merged

feat: add support new ctl #541

merged 12 commits into from
Dec 11, 2019

Conversation

hugomrdias
Copy link
Contributor

@hugomrdias hugomrdias commented Oct 11, 2019

Uses a new simpler and async tests setup and also makes use of the new jsdoc typedefs so we get code completion in this repo when writing new tests.

needs:

@alanshaw
Copy link
Contributor

jsdoc typedefs so we get code completion in this repo when writing new tests.

This sounds cool, how to I get this in my editor?

@hugomrdias
Copy link
Contributor Author

jsdoc typedefs so we get code completion in this repo when writing new tests.

This sounds cool, how to I get this in my editor?

jsdocs-tests

with vscode you should get this out of the box, otherwise this should work with any editor that supports or has an extension for the TS language server.

@hugomrdias hugomrdias changed the title feat: add support for a simpler and async test setup feat: add support new ctl Dec 4, 2019
Copy link
Contributor

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very mechanical

when running with a 'proc' pre-setup we could end up with multiples in-browser setup connecting to each other. whihc isnt a very useful situation.
with this the first node gets the pre-configured config and all the others get a JS daemon.
@alanshaw alanshaw merged commit a27cfa7 into master Dec 11, 2019
@alanshaw alanshaw deleted the feat/interface-tests branch December 11, 2019 17:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants