This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
This was referenced Oct 11, 2019
This sounds cool, how to I get this in my editor? |
42 tasks
achingbrain
approved these changes
Nov 6, 2019
hugomrdias
force-pushed
the
feat/interface-tests
branch
from
December 3, 2019 17:37
ecc4641
to
a942fb9
Compare
hugomrdias
changed the title
feat: add support for a simpler and async test setup
feat: add support new ctl
Dec 4, 2019
alanshaw
approved these changes
Dec 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very mechanical
when running with a 'proc' pre-setup we could end up with multiples in-browser setup connecting to each other. whihc isnt a very useful situation. with this the first node gets the pre-configured config and all the others get a JS daemon.
hugomrdias
force-pushed
the
feat/interface-tests
branch
from
December 10, 2019 14:13
8d89bb9
to
d347b2c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a new simpler and async tests setup and also makes use of the new jsdoc typedefs so we get code completion in this repo when writing new tests.
needs: