You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
Hi, currently unsubscribe method must take a reference to the handler and it forces me to keep a reference to it while it may not be ideal for some implementations.
Maybe unsubscribe(eventName) could be provided based on EventEmitter.removeAllListeners(eventName) and how floodsub is implemented (inherits EventEmitter).
I don't mind creating PR for this, just wonder if there's an issue with that first,
The text was updated successfully, but these errors were encountered:
Isan-Rivkin
changed the title
adding removeAllIsteners(eventName)
adding unsubscribe(eventName)
Feb 6, 2019
Hi, currently
unsubscribe
method must take a reference to thehandler
and it forces me to keep a reference to it while it may not be ideal for some implementations.Maybe
unsubscribe(eventName)
could be provided based on EventEmitter.removeAllListeners(eventName) and howfloodsub
is implemented (inherits EventEmitter).I don't mind creating PR for this, just wonder if there's an issue with that first,
The text was updated successfully, but these errors were encountered: