Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: golang version consolidation #31

Closed
SgtPooki opened this issue Jan 24, 2023 · 2 comments
Closed

chore: golang version consolidation #31

SgtPooki opened this issue Jan 24, 2023 · 2 comments

Comments

@SgtPooki
Copy link
Member

the golang version used for the docker container (1.17.8) is different than the golang version in the go.mod file (1.16).

https://github.com/ipfs-shipyard/ipfs-check/blob/83979b0b5449837a8bf027ced135cc29418b7006/go.mod#L3

vs

https://github.com/ipfs-shipyard/ipfs-check/blob/83979b0b5449837a8bf027ced135cc29418b7006/Dockerfile#L1

@aschmahmann
Copy link
Contributor

It's fine to update the go.mod version, but it's ok for them to not be the same. go.mod's Go version is basically the minimum Go "semantics" to use so you need to compile with Go >= the version in the go.mod file

@2color
Copy link
Member

2color commented Aug 6, 2024

@2color 2color closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants