Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ipfsPublicGateway and ipfsApi when opening webui #1022

Open
lidel opened this issue Sep 1, 2021 · 0 comments
Open

Set ipfsPublicGateway and ipfsApi when opening webui #1022

lidel opened this issue Sep 1, 2021 · 0 comments
Labels
exp/intermediate Prior experience is likely helpful kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up

Comments

@lidel
Copy link
Member

lidel commented Sep 1, 2021

Current state

Improvement

Companion should act as the source of truth. API and Gateway configured in Companion should always be explicitly set to the same value in ipfs-webui opened via Companion's "My Node' button etc.

Prior art

Companion sets ipfsApi and reloads webui (code) in Brave (which uses custom port). We could make this smarter and execute update of ipfsPublicGateway and ipfsApi every time URL in localStorage does not match one configured in Companion's Preferences.

@lidel lidel added kind/enhancement A net-new feature or improvement to an existing feature exp/intermediate Prior experience is likely helpful P2 Medium: Good to have, but can wait until someone steps up labels Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/intermediate Prior experience is likely helpful kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up
Projects
No open projects
Status: Needs Grooming
Development

No branches or pull requests

1 participant