Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linkify experimental feature - demo page shows unlinked "should be linkified" text #1050

Closed
SgtPooki opened this issue Feb 1, 2022 · 1 comment · Fixed by #1064
Closed

Linkify experimental feature - demo page shows unlinked "should be linkified" text #1050

SgtPooki opened this issue Feb 1, 2022 · 1 comment · Fixed by #1064
Assignees
@SgtPooki
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) kind/maintenance Work required to avoid breaking changes or harm to project's status quo P3 Low: Not priority right now status/in-progress In progress

Comments

@SgtPooki
Copy link
Member

SgtPooki commented Feb 1, 2022

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the linkify-demo page
  2. Notice that "ipns://ipfs.git.sexy" is not linkified (see screenshot below)

Expected behavior

All links under "Should be linkified" should be linkified.

Screenshots
image

Desktop (please complete the following information):

  • OS: macOS Monterey 12.1 (21C52)
  • Browser: Chrome
  • Version: 97.0.4692.99 (Official Build) (arm64)

Additional context

One of two fixes:

  1. "ipns://ipfs.git.sexy" should be linkified.
    or
  2. "ipns://ipfs.git.sexy" should not be listed under the "Should be linkified section"
@SgtPooki SgtPooki added the need/triage Needs initial labeling and prioritization label Feb 1, 2022
@lidel
Copy link
Member

lidel commented Feb 3, 2022 •
edited
Loading

Good catch! I guess this is because that domain name is dead and no longer has a valid DNSLink:
https://ipfs.io/ipns/ipfs.git.sexy/

@SgtPooki mind opening PR that replaces all uses of ipfs.git.sexy with en.wikipedia-on-ipfs.org ?

@ipfs ipfs deleted a comment from welcome bot Feb 3, 2022
@lidel lidel added effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) kind/maintenance Work required to avoid breaking changes or harm to project's status quo help wanted Seeking public contribution on this issue P3 Low: Not priority right now and removed need/triage Needs initial labeling and prioritization labels Feb 3, 2022
@James-E-A James-E-A mentioned this issue Feb 27, 2022
Open
@SgtPooki SgtPooki self-assigned this Mar 3, 2022
@SgtPooki SgtPooki added the status/in-progress In progress label Mar 3, 2022
@SgtPooki SgtPooki mentioned this issue Mar 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SgtPooki SgtPooki

Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) kind/maintenance Work required to avoid breaking changes or harm to project's status quo P3 Low: Not priority right now status/in-progress In progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: linkify tests ipfs/ipfs-companion
2 participants
@lidel @SgtPooki