Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firefox: toggle widget is broken #1103

Closed
lidel opened this issue Nov 22, 2022 · 3 comments · Fixed by #1105
Closed

Firefox: toggle widget is broken #1103

lidel opened this issue Nov 22, 2022 · 3 comments · Fixed by #1105
Assignees
@whizzzkid
Labels
area/firefox Issues related to Mozilla Firefox exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws)
Milestone
v2.20

Comments

@lidel
Copy link
Member

lidel commented Nov 22, 2022

Something I missed in #1054 – the toggle widget is b0rked on Options screen behind ⚙️ icon (toggling works, but wisually broken):

Expected:

2022-11-22_04-13

Actual:

2022-11-22_02-55

@whizzzkid would you be able to take a look before our call on Thursday? If not we can push it to next week.
@lidel lidel added the need/triage Needs initial labeling and prioritization label Nov 22, 2022
@lidel lidel added this to the v2.20 milestone Nov 22, 2022
@galargh galargh moved this to To do in IPFS-GUI (PL EngRes) Nov 22, 2022
@whizzzkid
Copy link
Contributor

@lidel so it looks likes it's not an issue on chrome, but on firefox, it's unable to load fonts and fails with downloadable font: rejected by sanitizer I'm still investigating to fix this.

@whizzzkid whizzzkid added kind/bug A bug in existing code (including security flaws) exp/intermediate Prior experience is likely helpful area/firefox Issues related to Mozilla Firefox and removed need/triage Needs initial labeling and prioritization labels Nov 24, 2022
@whizzzkid whizzzkid mentioned this issue Nov 24, 2022
Merged
@whizzzkid whizzzkid self-assigned this Nov 24, 2022
@lidel
Copy link
Member Author

lidel commented Nov 24, 2022

Ack, last time I looked into this Firefox was already stricter around CSP than Google.

  • We may need to adjust content_security_policy in add-on/manifest.firefox.json or change the way fonts are bundled.
    • @whizzzkid (fyi, in case its useful) fonts bundled with ipfs-css may be out of date, we have now updated brand guidelines (first two links here) and iirc font changed. it may be easier to update ipfs-css and switch to new fonts than try to fix old ones.

@lidel lidel changed the title Toggle widget seems broken Firefox: toggle widget is broken Nov 24, 2022
Repository owner moved this from Needs Grooming to Done in IPFS-GUI (PL EngRes) Nov 24, 2022
@whizzzkid
Copy link
Contributor

@lidel I have a fix for the CSP, but the update-manifest.sh likes to revert the manifests on every run. Looks like it needs to be a two step process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whizzzkid whizzzkid

Labels
area/firefox Issues related to Mozilla Firefox exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws)
Projects
No open projects
IPFS-GUI (PL EngRes)
Archived in project
Milestone
v2.20
Development

Successfully merging a pull request may close this issue.

fix: toggle buttons on Firefox ipfs/ipfs-companion
2 participants
@lidel @whizzzkid