Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(telemetry): ✨ Adding companion version to segments #1142

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

whizzzkid
Copy link
Contributor

Closes: #1138

In this PR:

  • Reporting ipfs-companion version as a segment.

@whizzzkid whizzzkid requested review from lidel and a team as code owners January 31, 2023 02:54
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but would like to get 👍 and thoughts on below questions from @SgtPooki who has more holistic view of telemetry.

My questions (none of them blocking)

  1. (could be separate PR) would it be useful to also read arch and os via browser.runtime.getPlatformInfo?
  2. (just cosmetics) Is is necessary (e.g., due to the way countly metrics work) to to send this with every view event? (these values are static, doing it once during startup here would tell us the same)

@whizzzkid
Copy link
Contributor Author

@lidel I can create a follow-up for providing arch and os for the second, we would need to setup user metrics to be collected by registering them against a unique identifier (deviceId) and then have sessions with the info setup first. We currently don't do that, but we can, I created an issue: ipfs-shipyard/ignite-metrics#87 I'll merge this for now and we can carry our discussions there.

@whizzzkid whizzzkid merged commit 65fe66c into main Feb 1, 2023
@whizzzkid whizzzkid deleted the feat/ipfs-companion-version-in-telemetry branch February 1, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telemetry: Add Companion Version as a Segment
2 participants