Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port "linkify plaintext IPFS links" #202

Closed
lidel opened this issue Feb 12, 2017 · 0 comments
Closed

Port "linkify plaintext IPFS links" #202

lidel opened this issue Feb 12, 2017 · 0 comments

Comments

@lidel
Copy link
Member

lidel commented Feb 12, 2017 •
edited
Loading

It is not possible to port code introduced in #39 to WebExtension so I'll do a PoC rewrite using available APIs.

Initial assumptions:

  • disabled by default
  • do not use content script – inject simplified content script via tabs.executeScript only if tab finished loading and linkification is enabled in add-on options
  • do not rewrite relative links – this should've been a separate option anyway
  • rewrite to public gateway due to missing custom handler (Support Custom Protocols in WebExtension #164)
@lidel lidel closed this as completed in b8f6517 Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lidel