Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX when API is unstable #614

Closed
fiatjaf opened this issue Nov 5, 2018 · 4 comments
Closed

Improve UX when API is unstable #614

fiatjaf opened this issue Nov 5, 2018 · 4 comments
Labels
status/ready Ready to be worked

Comments

@fiatjaf
Copy link

fiatjaf commented Nov 5, 2018

When browsing a web page that does 4 simultaneous ipfs.dht.findprovs and one ipfs.object.stat calls, sometimes the companion crashes.

I start seeing lots of ERROR engine: open /home/fiatjaf/.ipfs/datastore/004159.ldb: too many open files engine.go:258 in the daemon logs.

Then the web page calls to ipfs fail silently, I think.

The IPFS Companion status window starts showing everything offline,
2018-11-05-084545_156x181_scrot

and then if I restart the daemon I get
2018-11-05-084742_334x996_scrot

If I wait more, the status window comes back to normal, but in the meantime some, or all, of my ipfs.dht.findprovs have already failed silently.

@fiatjaf fiatjaf changed the title IPFS Companion crashes IPFS Companion crashes / too many open files? Nov 5, 2018
@lidel lidel added the UX label Nov 5, 2018
@lidel
Copy link
Member

lidel commented Nov 5, 2018

@fiatjaf thank you for reporting this with all the details!

Then the web page calls to ipfs fail silently, I think.

Correct. I see the go-ipfs part ("too many open files") is tracked in ipfs/kubo#5739, so let's keep this issue about how ipfs-companion should behave in such situations.

  • the UI is faded out if API is unreachable (this seems to work as expected)
  • idempotent notifications (there should be no duplicates)

Is there anything else we should improve here UX-wise?

@lidel lidel added the status/ready Ready to be worked label Nov 5, 2018
@lidel lidel changed the title IPFS Companion crashes / too many open files? Improve UX when API is unstable Nov 5, 2018
@fiatjaf
Copy link
Author

fiatjaf commented Nov 5, 2018

Well, this is probably unrelated but I would like stuff being printed to the console when the Companion is doing work. Perhaps there could be a debug mode I could put the extension on so that it would start printing a lot of things? I don't know.

Currently (at least on Firefox) nothing shows up in the Network tab, nothing is printed to the console. Things that fail silently are very annoying, but I can't even know they're failing silently, maybe they're just not failing and taking a lot of time.

@lidel
Copy link
Member

lidel commented Nov 6, 2018

I agree! Been playing with verbose logs that can also be filtered via Preferences screen in #557. The PR was parked due to a dependency bug, but I see that got released recently, so it may be a good idea to get back to it in near future :)

@lidel
Copy link
Member

lidel commented Oct 17, 2019

Closing updates:

@lidel lidel closed this as completed Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/ready Ready to be worked
Projects
None yet
Development

No branches or pull requests

2 participants