Add warning about mixed content issues #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
olizilla
approved these changes
Jan 2, 2019
Co-Authored-By: lidel <lidel@lidel.org>
da2x
suggested changes
Jan 3, 2019
|
Sorry, but I forgot about IPv6 in #648. It’s one more valid address that is whitelisted as secure by browsers. The inclusion of a third address does make the warning message messy, though. Not sure how to improve it without reformatting it as a list or maybe even linking to a wiki page with valid addresses and more information? |
|
Good catch @da2x! I've added it and it's not that bad actually (a technical person will know what's up, a non-technical won't need to touch this field anyway). ps. ipv6 looks really nice in location bar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR checks if URL would trigger mixed content error and if check is positive displays an inline warning message:
@olizilla does the copy look ok?