Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

false-negative in CID parsing by ipfs:// handler #709

Closed
lidel opened this issue Apr 9, 2019 · 1 comment · Fixed by #835
Closed

false-negative in CID parsing by ipfs:// handler #709

lidel opened this issue Apr 9, 2019 · 1 comment · Fixed by #835
Labels
kind/bug A bug in existing code (including security flaws) status/deferred Conscious decision to pause or backlog

Comments

@lidel
Copy link
Member

lidel commented Apr 9, 2019

Companion v2.8.1

ipfs://bafybeihlni3zz7o6ij2twmyndhxxdjp56v35t57ghdqer2oq2kj6o42l5m redirects to error page, but the CID is valid: https://bafybeihlni3zz7o6ij2twmyndhxxdjp56v35t57ghdqer2oq2kj6o42l5m.ipfs.dweb.link/
@lidel lidel added kind/bug A bug in existing code (including security flaws) status/deferred Conscious decision to pause or backlog labels Apr 9, 2019
@lidel
Copy link
Member Author

lidel commented Dec 9, 2019 •
edited
Loading

Similar false-negative error happens when opening valid ipfs:// in Incognito window (companion integrations are disabled, but handler is globally registered).

  • update routing page to detect lack of companion and redirect to resource on public gateway.

@lidel lidel mentioned this issue Dec 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws) status/deferred Conscious decision to pause or backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ipfs:// in Firefox incognito window ipfs/ipfs-companion
1 participant
@lidel