Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to pin content locally? #917

Closed
jessicaschilling opened this issue Aug 24, 2020 · 1 comment
Closed

Add option to pin content locally? #917

jessicaschilling opened this issue Aug 24, 2020 · 1 comment
Labels
area/pinning Integrating pinning into GUI apps effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful kind/architecture Core architecture of project kind/discussion Topical discussion; usually not changes to codebase kind/enhancement A net-new feature or improvement to an existing feature

Comments

@jessicaschilling
Copy link
Contributor

Question from HackFS participant:
When using the IPFS Companion extension, is there a way to create a button to let users pin this content locally?

cc @autonome for clarification: We've got the pin toggle in the main extension menu (cube menu); is this instead referring to a right-click option when clicking on an item that could be imported to IPFS?

@jessicaschilling jessicaschilling added need/triage Needs initial labeling and prioritization area/pinning Integrating pinning into GUI apps exp/intermediate Prior experience is likely helpful effort/days Estimated to take multiple days, but less than a week kind/enhancement A net-new feature or improvement to an existing feature need/analysis Needs further analysis before proceeding P2 Medium: Good to have, but can wait until someone steps up labels Aug 24, 2020
@lidel
Copy link
Member

lidel commented Aug 25, 2020

I remember this question, in the thread it was clarified the person meant a cross-origin button like those twitter/facebook ones from the past:

2020-08-25--18-27-59

With #777 we moved away from injecting anything into the page contexts, and the current climate on the web is is moving away from "facebook button".

So the short answer is no, there is no way to create such button atm.


That being said, one can pin the currently loaded resource via ipfs-companion browser extension, just like @jessicaschilling hinted at:

2020-08-25--18-24-03

This is the only safe way of doing this without asking user to manually whitelist Origin via CORS etc.

ps. We will be revamping pinning UI in Companion after support for Pinning Services Integration lands (tracked in epic at ipfs/ipfs-gui#91)

@lidel lidel closed this as completed Aug 25, 2020
@lidel lidel added kind/architecture Core architecture of project kind/discussion Topical discussion; usually not changes to codebase and removed need/analysis Needs further analysis before proceeding need/triage Needs initial labeling and prioritization P2 Medium: Good to have, but can wait until someone steps up labels Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/pinning Integrating pinning into GUI apps effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful kind/architecture Core architecture of project kind/discussion Topical discussion; usually not changes to codebase kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants