Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ipfs-http-client >42 (refactor with Async Await and Async Iterables) #1431

Closed
lidel opened this issue Apr 4, 2020 · 0 comments · Fixed by #1569
Closed

Use ipfs-http-client >42 (refactor with Async Await and Async Iterables) #1431

lidel opened this issue Apr 4, 2020 · 0 comments · Fixed by #1569
Labels
effort/weeks Estimated to take multiple weeks exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue kind/maintenance Work required to avoid breaking changes or harm to project's status quo P0 Critical: Tackled by core team ASAP status/ready Ready to be worked
Milestone
v2.11

Comments

@lidel
Copy link
Member

lidel commented Apr 4, 2020

js-ipfs 41 introduced breaking changes to the programmatic JS API:
https://blog.ipfs.io/2020-02-13-js-ipfs-0-41/

The same programmatic API is exposed by the latest ipfs-http-client which is a dependency of ipfs-redux-bundle used by webui for connecting to the HTTP API of IPFS node.

While switching to the latest API, remove patch/hotfix introduced in #1430
@lidel lidel added help wanted Seeking public contribution on this issue exp/expert Having worked on the specific codebase is important P0 Critical: Tackled by core team ASAP status/ready Ready to be worked kind/maintenance Work required to avoid breaking changes or harm to project's status quo effort/weeks Estimated to take multiple weeks labels Apr 4, 2020
@lidel lidel pinned this issue Apr 4, 2020
@lidel lidel mentioned this issue Apr 4, 2020
Merged
@Gozala Gozala mentioned this issue Aug 4, 2020
Merged
@lidel lidel added this to the v2.11 milestone Aug 11, 2020
@jessicaschilling jessicaschilling unpinned this issue Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/weeks Estimated to take multiple weeks exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue kind/maintenance Work required to avoid breaking changes or harm to project's status quo P0 Critical: Tackled by core team ASAP status/ready Ready to be worked
Projects
None yet
Milestone
v2.11
Development

Successfully merging a pull request may close this issue.

Migration to the new IPFS JS API with Async Await and Async Iterables ipfs/ipfs-webui
1 participant
@lidel