Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peers screen: Improve responsive display #1609

Open
jessicaschilling opened this issue Sep 1, 2020 · 3 comments
Open

Peers screen: Improve responsive display #1609

jessicaschilling opened this issue Sep 1, 2020 · 3 comments
Labels
area/screen/peers Issues related to Peers screen effort/days Estimated to take multiple days, but less than a week exp/beginner Can be confidently tackled by newcomers P3 Low: Not priority right now status/inactive No significant work in the previous month

Comments

@jessicaschilling
Copy link
Contributor

jessicaschilling commented Sep 1, 2020

The problem

The current-state Peers screen looks fine at wide desktop resolutions (below, 1440px wide) ...
image

However, both the map and the peers table deteriorate significantly at narrower widths, regardless of height:

  • 768px wide (table columns start to break):
    image
  • 425px wide (map cropped horizontally, table unusable):
    image

Additionally, map display degrades substantially at non-16x9ish aspect ratios due to the map dimensions being pegged to percentage of total screen height:

  • 1024x385 (map unusably small, gets lost in its surrounding white space):
    image
  • 320x911 (map unusably cropped):
    image

Need in brief

Improve the responsive display of the Peers screen so both the map and the table are as functional at mobile widths and unusual aspect ratios as they are in the standard 16x9, 1440px+ display. This is likely to (but will not necessarily) include:

  • Mobile-friendly (e.g. pinch + scale button) zoom/pan controls for peers map
  • Side-scroll for peers table

Please note that react-virtualized is used not only for the table on the Peers screen, but also for tables on other screens of the app. If replacing react-virtualized is part of a proposed solution, please also solve for how to implement elsewhere in Web UI.

Acceptance criteria

Solution must ...

  • Not sacrifice any functionality of full-sized display
  • Gracefully adjust when aspect ratio and display dimensions are resized (e.g. from portrait to landscape on a phone/tablet)
  • Display gracefully at and between the following display widths:
    • 320x568 (small phone portrait)
    • 568x320 (small phone landscape)
    • 375x667 (medium phone portrait)
    • 667x375 (medium phone landscape)
    • 414x736 (large phone portrait)
    • 736x414 (large phone landscape)
    • 768x1024 (small tablet portrait)
    • 1024x768 (small tablet landscape)
  • Display as gracefully as possible at extreme desktop-browser-window aspect ratios (e.g. but not limited to 400x1200, 1200x400, etc)
@jessicaschilling
Copy link
Contributor Author

@lidel and @rafaelramalho19 -- thoughts on this issue's definition and acceptance criteria for potential inclusion on the bounty board?

@lidel
Copy link
Member

lidel commented Sep 21, 2020

@jessicaschilling apologies, missed this one. I think this makes a perfect bounty, but to avoid duplicated work, would wait until we land #1602/#1616, and then see if acceptance criteria still make sense with the more dense table.

@jessicaschilling
Copy link
Contributor Author

+1. I suspect we'll need side-scroll on this table regardless of where we come out with those issues, but good plan.

@SgtPooki SgtPooki added P3 Low: Not priority right now status/blocked Unable to be worked further until needs are met effort/days Estimated to take multiple days, but less than a week area/screen/peers Issues related to Peers screen status/inactive No significant work in the previous month exp/beginner Can be confidently tackled by newcomers and removed status/blocked Unable to be worked further until needs are met labels Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/screen/peers Issues related to Peers screen effort/days Estimated to take multiple days, but less than a week exp/beginner Can be confidently tackled by newcomers P3 Low: Not priority right now status/inactive No significant work in the previous month
Projects
No open projects
Status: UX Design Needed
Development

No branches or pull requests

3 participants