Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The private network browsing file references the ipfs.io gateway #1767

Closed
zemelLeong opened this issue Apr 21, 2021 · 2 comments · Fixed by #1834
Closed

The private network browsing file references the ipfs.io gateway #1767

zemelLeong opened this issue Apr 21, 2021 · 2 comments · Fixed by #1834
Assignees
@hacdias
Labels
area/screen/files Issues related to Files screen effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) need/analysis Needs further analysis before proceeding P2 Medium: Good to have, but can wait until someone steps up

Comments

@zemelLeong
Copy link

Describe the bug
The private network browsing local cluster file references the ipfs.io gateway.
image
@zemelLeong zemelLeong added the need/triage Needs initial labeling and prioritization label Apr 21, 2021
@lidel lidel added the need/analysis Needs further analysis before proceeding label May 21, 2021
@lidel lidel self-assigned this May 21, 2021
@ipfs ipfs deleted a comment from welcome bot Jun 18, 2021
@lidel lidel added area/screen/files Issues related to Files screen kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful and removed need/triage Needs initial labeling and prioritization labels Jun 18, 2021
@lidel
Copy link
Member

lidel commented Jun 18, 2021

Fix here is to provide two links: "open on ipfs.io" + "open on local gateway"

@lidel lidel removed their assignment Jun 18, 2021
@lidel
Copy link
Member

lidel commented Jun 30, 2021

This may be caused by ipfs/kubo#8230 – webui uses that CID for testing if local gateway is available.

@hacdias hacdias self-assigned this Aug 14, 2021
@hacdias hacdias mentioned this issue Aug 14, 2021
Merged
@tinytb tinytb moved this to Done in IP JS (PL EngRes) v2 Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hacdias hacdias

Labels
area/screen/files Issues related to Files screen effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) need/analysis Needs further analysis before proceeding P2 Medium: Good to have, but can wait until someone steps up
Projects
No open projects
IP JS (PL EngRes) v2
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: local and public gateway links when cannot preview ipfs/ipfs-webui
3 participants
@lidel @hacdias @zemelLeong