Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not specify replication factor when pinning - use cluster's default #2302

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

hsanjuan
Copy link
Contributor

This was not a good idea when pinning to collab clusters...

This was not a good idea when pinning to collab clusters...
@hsanjuan hsanjuan requested a review from a team as a code owner November 28, 2024 11:13
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vaguely remember this was either workaround to not wait for all cluster nodes to confirm pinning, or break when not all nodes are online.

Either way, let's merge and figure out if still an issue once we make the next release
If CI timeouts, one thing we could do, is to send a CAR, rather than pinning CID and waiting for bitswap
(cc @SgtPooki for visibility)

@lidel lidel merged commit 81b8f29 into main Nov 29, 2024
21 checks passed
@lidel lidel deleted the replication-factor branch November 29, 2024 00:34
@hsanjuan
Copy link
Contributor Author

ahh, yes could be! That cluster has a 3rd party peer that is broken to all effects. Direct CAR upload with --local is definitely the best.

dist.ipfs.io pins without --wait and then waits itself for things to be pinned in at least one peer:

echo "::group::pin add"
ipfs-cluster-ctl --enc=json \
    --host "/dnsaddr/ipfs-websites.collab.ipfscluster.io" \
    --basic-auth "${CLUSTER_USER}:${CLUSTER_PASSWORD}" \
    pin add \
    --name "${PIN_NAME}" \
    --no-status $PIN_ADD_EXTRA_ARGS \
    "$PIN_CID"
echo "::endgroup::"

# TODO: below can now be replaced with ipfs-cluster-ctl --wait now (https://github.com/ipfs/ipfs-cluster/blob/v0.14.1/CHANGELOG.md#v0141---2021-08-18)
echo "::group::waiting until pinned"
    while true; do
    ipfs-cluster-ctl --enc=json \
        --host "/dnsaddr/ipfs-websites.collab.ipfscluster.io" \
        --basic-auth "${CLUSTER_USER}:${CLUSTER_PASSWORD}" \
        status "$PIN_CID" | tee cluster-pin-status
    if [[ $(jq '.peer_map[].status' cluster-pin-status | grep '"pinned"' | wc -l) -ge 1 ]]; then
        echo "Got first pin confirmation, finishing the workflow"
        break
    else
        echo "Still waiting for at least one pin confirmation, sleeping for 1 minute.."
        sleep 60
    fi
    done
echo "::endgroup::"

ipfs-gui-bot pushed a commit that referenced this pull request Nov 30, 2024
## [4.4.1](v4.4.0...v4.4.1) (2024-11-30)

 CID `bafybeiatztgdllxnp5p6zu7bdwhjmozsmd7jprff4bdjqjljxtylitvss4`

 ---

### Bug Fixes

* add lithuanian to languages.json ([#2293](#2293)) ([40c512b](40c512b))
* analyze script doesn't persist stats.json ([#2290](#2290)) ([dbbdd70](dbbdd70))
* **explore:** browsing chunked files and inspecting via context menu ([#2305](#2305)) ([0412970](0412970)), closes [#2306](#2306)

### Trivial Changes

* **ci:** add CAR file directly to cluster ([#2304](#2304)) ([e2ae110](e2ae110))
* **ci:** no replication factor when pinning - use cluster's default ([#2302](#2302)) ([81b8f29](81b8f29))
* **ci:** set cluster pin timeout to 30m ([4b8fc00](4b8fc00))
* **ci:** udpate artifact actions to v4 ([#2292](#2292)) ([305908f](305908f))
* **ci:** use repo in offline mode ([eaf63ed](eaf63ed))
* pull new translations ([#2291](#2291)) ([bfe7e40](bfe7e40))
* pull transifex translations ([#2296](#2296)) ([502abd4](502abd4))
* pull transifex translations ([#2303](#2303)) ([89c094b](89c094b))
* size-related labels in Files screen ([#2295](#2295)) ([49019d4](49019d4))
@ipfs-gui-bot
Copy link
Collaborator

🎉 This PR is included in version 4.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

MattWong-ca pushed a commit to MattWong-ca/ipfs-webui that referenced this pull request Dec 14, 2024
## [4.4.1](ipfs/ipfs-webui@v4.4.0...v4.4.1) (2024-11-30)

 CID `bafybeiatztgdllxnp5p6zu7bdwhjmozsmd7jprff4bdjqjljxtylitvss4`

 ---

### Bug Fixes

* add lithuanian to languages.json ([ipfs#2293](ipfs#2293)) ([40c512b](ipfs@40c512b))
* analyze script doesn't persist stats.json ([ipfs#2290](ipfs#2290)) ([dbbdd70](ipfs@dbbdd70))
* **explore:** browsing chunked files and inspecting via context menu ([ipfs#2305](ipfs#2305)) ([0412970](ipfs@0412970)), closes [ipfs#2306](ipfs#2306)

### Trivial Changes

* **ci:** add CAR file directly to cluster ([ipfs#2304](ipfs#2304)) ([e2ae110](ipfs@e2ae110))
* **ci:** no replication factor when pinning - use cluster's default ([ipfs#2302](ipfs#2302)) ([81b8f29](ipfs@81b8f29))
* **ci:** set cluster pin timeout to 30m ([4b8fc00](ipfs@4b8fc00))
* **ci:** udpate artifact actions to v4 ([ipfs#2292](ipfs#2292)) ([305908f](ipfs@305908f))
* **ci:** use repo in offline mode ([eaf63ed](ipfs@eaf63ed))
* pull new translations ([ipfs#2291](ipfs#2291)) ([bfe7e40](ipfs@bfe7e40))
* pull transifex translations ([ipfs#2296](ipfs#2296)) ([502abd4](ipfs@502abd4))
* pull transifex translations ([ipfs#2303](ipfs#2303)) ([89c094b](ipfs@89c094b))
* size-related labels in Files screen ([ipfs#2295](ipfs#2295)) ([49019d4](ipfs@49019d4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants