Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user I can add & remove nodes to/from a testbed #81

Open
frrist opened this issue Sep 10, 2018 · 2 comments
Open

As a user I can add & remove nodes to/from a testbed #81

frrist opened this issue Sep 10, 2018 · 2 comments
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature need/community-input Needs input from the wider community

Comments

@frrist
Copy link
Member

frrist commented Sep 10, 2018

The add command should be added as a subcommand to the existing testbed command. e.g.

Create a testbed:
iptb testbed create --count 5 --type localipfs

Add 3 nodes to the testbed
iptb testbed add --count 3 --type localipfs

There are a couple different ways to handle remove, whomever decides to pick this up -- let's have a discussion here before implementing 😄

@frrist frrist added kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue exp/expert Having worked on the specific codebase is important labels Sep 10, 2018
@frrist frrist changed the title As a user I can add nodes to a testbed As a user I can add & remove nodes to/from a testbed Sep 12, 2018
@frrist frrist added the need/community-input Needs input from the wider community label Sep 12, 2018
@dgrisham
Copy link
Member

With this, would we allow mixing node types, e.g.

$ iptb testbed create --count 2 --type localipfs
$ iptb testbed add --count 2 --type dockeripfs

? Or would we ensure that you could only add nodes of the same type that the testbed already has? From what I've seen I don't think mixing node types would break anything, and I could see that being potentially useful (e.g. one local node that talks to a bunch of docker nodes).

@frrist
Copy link
Member Author

frrist commented Oct 17, 2018

I think initially restricting this to the same testbed will make implementation easier, later we can expand this to work with multiple testbeds (probably deserves its own issue).

From what I've seen I don't think mixing node types would break anything, and I could see that being potentially useful

I agree with will be very useful, however, as an example, getting a docker plugin to work with a local plugin will require that the docker file is written such that the appropriate ports are exposed for connection, and that the containers can be dialed by local processes -- could be tricky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature need/community-input Needs input from the wider community
Projects
None yet
Development

No branches or pull requests

2 participants