Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak? #5

Closed
alanshaw opened this issue Oct 18, 2018 · 0 comments
Closed

Memory leak? #5

alanshaw opened this issue Oct 18, 2018 · 0 comments
Assignees
@vasco-santos
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@alanshaw
Copy link
Member

If I call get for the same key, it'll call pubsub.subscribe and add another handler for the same key.

js-datastore-pubsub/src/index.js

Line 90 in d59878d

this._pubsub.subscribe(stringifiedTopic, this._handleSubscription, (err) => {

I think we only want one handler per key right?
@vasco-santos vasco-santos self-assigned this Oct 18, 2018
@vasco-santos vasco-santos added the kind/bug A bug in existing code (including security flaws) label Oct 18, 2018
@vasco-santos vasco-santos mentioned this issue Oct 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vasco-santos vasco-santos

Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alanshaw @vasco-santos