Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Windows interop #624

Merged
merged 8 commits into from
Nov 14, 2017
Merged

Windows interop #624

merged 8 commits into from
Nov 14, 2017

Conversation

richardschneider
Copy link
Contributor

See the discussion at #623

@ghost ghost added the in progress label Nov 12, 2017
@daviddias
Copy link
Contributor

Pulling discussion from #623 (comment)


@richardschneider mind opening a PR on js-ipfs-api?

diag.sys [Error: this operation is not supported on your platform]

We can have a flag that disables this test for Windows, it's ok.

dial attempt failed: context deadline exceeded

Do you know what it was trying to dial to?

.swarm.addrs Uncaught AssertionError: expected [] not to be empty

Sounds like this failed due to the previous dial fail

.swarm.peers timeout

Increase the timeout?

various issues with addFromFs

Reported here #408

a few tests are getting different hash IDs

Weird, which ones?

@daviddias
Copy link
Contributor

@thisconnect
Copy link

There are a few slashes '/' in get-files-stream.js https://github.com/ipfs/js-ipfs-api/blob/master/src/utils/get-files-stream.js#L49 and possible in other places. Not sure if they matter but could you try with path.sep https://nodejs.org/api/path.html#path_path_sep ?

@richardschneider
Copy link
Contributor Author

@thisconnect Thanks. I plan to work on this code today. There are two issues:

  • the file name is resolved so will have os-specific separator
  • glob wants forward slashes

@richardschneider
Copy link
Contributor Author

On my local windows I'm getting ECONNREFUSED in https://github.com/ipfs/js-ipfs-api/blob/master/test/ipfs-factory/client.js

It is trying to talk to localhost:55155
Who is listening to this port? And why is it hardcoded?

@richardschneider
Copy link
Contributor Author

Solved the port 55155 issue. I was using mocha directly to only run a few tests. The tests do NOT spin up a test server. That is aegir responsibility, so I didn't have a test server. Better error messages could have saved me a few hours.

@richardschneider
Copy link
Contributor Author

@diasdavid I have made the minor changes to get this running on Windows.

All the red lights have nothing to do with Windows and are pre-existing problems.

Code: 'n/a',
Message: err
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

it('skip these on Windows')
return
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@daviddias
Copy link
Contributor

I haven't seen this error before:
image

@richardschneider
Copy link
Contributor Author

The code can NOT handle x-stream-error correctly. See request-api

// TODO: This needs reworking.
// this is a chicken and egg problem -
// 1) we can't get Trailer headers unless the response ends
// 2) we can't propagate the error, because the response stream
// is closed
// (perhaps we can workaround this using pull-streams)

@ghost ghost assigned daviddias Nov 14, 2017
@daviddias daviddias merged commit 40557d0 into master Nov 14, 2017
@daviddias daviddias deleted the windows-interop branch November 14, 2017 09:03
@ghost ghost removed the in progress label Nov 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants