Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Add Stat Commands #639

Merged
merged 3 commits into from
Dec 5, 2017
Merged

Add Stat Commands #639

merged 3 commits into from
Dec 5, 2017

Conversation

hacdias
Copy link
Contributor

@hacdias hacdias commented Dec 4, 2017

That ^^ /cc @diasdavid

@ghost ghost assigned hacdias Dec 4, 2017
@ghost ghost added the in progress label Dec 4, 2017
Copy link
Contributor

@nunofmn nunofmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Maybe you could also update the sub-modules.spec.js tests to add the stat sub-module test and update the README.

@codecov
Copy link

codecov bot commented Dec 4, 2017

Codecov Report

Merging #639 into master will decrease coverage by 0.45%.
The diff coverage is 52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #639      +/-   ##
==========================================
- Coverage   84.02%   83.56%   -0.46%     
==========================================
  Files         115      119       +4     
  Lines        1746     1771      +25     
==========================================
+ Hits         1467     1480      +13     
- Misses        279      291      +12
Impacted Files Coverage Δ
src/utils/load-commands.js 100% <ø> (ø) ⬆️
src/stats/index.js 100% <100%> (ø)
src/stats/bitswap.js 42.85% <42.85%> (ø)
src/stats/bw.js 42.85% <42.85%> (ø)
src/stats/repo.js 42.85% <42.85%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f1ccdc...72df6bf. Read the comment docs.

@hacdias
Copy link
Contributor Author

hacdias commented Dec 4, 2017

Done @nunofmn! 😄

Copy link
Contributor

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @hacdias do you have time to take @nunofmn suggestion?

@hacdias
Copy link
Contributor Author

hacdias commented Dec 5, 2017 via email

@hacdias
Copy link
Contributor Author

hacdias commented Dec 5, 2017

Added to readme!

@daviddias daviddias merged commit 76c3068 into master Dec 5, 2017
@daviddias daviddias deleted the stats branch December 5, 2017 07:59
@ghost ghost removed the in progress label Dec 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants