This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 299
Add Stat Commands #639
Merged
Add Stat Commands #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunofmn
reviewed
Dec 4, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Maybe you could also update the sub-modules.spec.js
tests to add the stat
sub-module test and update the README.
Codecov Report
@@ Coverage Diff @@
## master #639 +/- ##
==========================================
- Coverage 84.02% 83.56% -0.46%
==========================================
Files 115 119 +4
Lines 1746 1771 +25
==========================================
+ Hits 1467 1480 +13
- Misses 279 291 +12
Continue to review full report at Codecov.
|
Done @nunofmn! 😄 |
daviddias
approved these changes
Dec 5, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. I can update the readme :)
…On Tue, 5 Dec 2017 at 07:07, David Dias ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM. @hacdias <https://github.com/hacdias> do you have time to take
@nunofmn <https://github.com/nunofmn> suggestion?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#639 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFMdsMNWdA7FQOfwUfSoHbKPjpKT09IAks5s9Os1gaJpZM4Q1Mrv>
.
|
Added to readme! |
daviddias
approved these changes
Dec 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That ^^ /cc @diasdavid