This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
fix: bundle in meteor #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Excluding `ipfs-http-client` in the `browser` field of package.json was causing Meteor to not include the bundle in it's browser build. fixes #10411 License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
ghost
assigned 
hugomrdias
approved these changes
Jan 23, 2019
|
@alanshaw it was something with js-ipfsd-ctl tests in the browser. Wanna give it a spin first with this version? |
|
yep will do 👍 |
|
Browser tests all passing in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including
ipfs-http-clientin thebrowserfield of package.json was causing Meteor to not include the bundle in it's browser build.I have no idea why it is there! @daviddias do you remember why it was added?
fixes #924