This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
fix multipart/form-data #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://tools.ietf.org/html/rfc7578#section-4.2, in a Content-Disposition header of a part in a multipart/form-data body: - the disposition must be of type `form-data` - a `name` parameter (not explicitely specified by the RFC, but I suppose non-empty) As this `name` parameter is unused by IPFS, this commit simply generate a placeholder with a counter, to conform to the HTTP specification.
MichaelMure
force-pushed
the
fix-multipart
branch
from
3ac0f0f
to
d1af3a7
Compare
|
for this to work ipfs/multipart needs to support this, or else js-ipfs api will break. |
I think it is already supported. https://github.com/ipfs/js-ipfs-multipart/blob/master/src/parser.js#L18 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the counterpart of ipfs/go-ipfs-files#8
According to https://tools.ietf.org/html/rfc7578#section-4.2, in a Content-Disposition header
of a part in a multipart/form-data body:
form-datanameparameter (not explicitely specified by the RFC, but I suppose non-empty)As this
nameparameter is unused by IPFS, this commit simply generate a placeholder witha counter, to conform to the HTTP specification.
I couldn't test properly that this fix actually works properly, so please test thoroughly.