Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move http class into ipfs-http-client #32

Closed
achingbrain opened this issue Apr 7, 2020 · 2 comments
Closed

Move http class into ipfs-http-client #32

achingbrain opened this issue Apr 7, 2020 · 2 comments

Comments

@achingbrain
Copy link
Member

Do we use this anywhere else? Does it really need to be here? We need to do things that make it less of a general-purpose http request module like restrict it only to POST requests etc so I'm not sure it belongs here any more.
@achingbrain achingbrain mentioned this issue Apr 9, 2020
Merged
@achingbrain
Copy link
Member Author

I think we actually use the http client in core so maybe don't remove this entirely, but can definitely have a non-generic http client for the http api client.

@hugomrdias
Copy link
Member

im using it in aegir and ipfsd-ctl at least.. http-client uses a wrapper around it can't we just change that ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hugomrdias @achingbrain