From 61ba99ef79e5512099b439e645e10e30a086a763 Mon Sep 17 00:00:00 2001 From: Alan Shaw Date: Wed, 30 May 2018 12:29:03 +0100 Subject: [PATCH] fix: adds missing breaking changes for 0.29 to changelog (#1370) --- CHANGELOG.md | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5001010d29..e74224c037 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -53,10 +53,16 @@ ### BREAKING CHANGES -* pubsub.unsubscribe is now async and argument order for pubsub.subscribe has changed - -License: MIT -Signed-off-by: Alan Shaw +1. Argument order for `pubsub.subscribe` has changed: + * Old: `pubsub.subscribe(topic, [options], handler, [callback]): Promise` + * New: `pubsub.subscribe(topic, handler, [options], [callback]): Promise` +2. The `pubsub.unsubscribe` method has become async meaning that it now takes a callback or returns a promise: + * Old: `pubsub.unsubscribe(topic, handler): undefined` + * New: `pubsub.unsubscribe(topic, handler, [callback]): Promise` +3. Property names on response objects for `ping` are now lowered: + * Old: `{ Success, Time, Text }` + * New: `{ success, time, text }` +4. In the CLI, `jsipfs object data` no longer returns a newline after the end of the returned data