fix: cat: test file existence after filtering #1148
Conversation
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #1148 +/- ##
==========================================
+ Coverage 83.64% 83.66% +0.01%
==========================================
Files 122 122
Lines 2740 2749 +9
==========================================
+ Hits 2292 2300 +8
- Misses 448 449 +1
Continue to review full report at Codecov.
|
|
@alanshaw can you test with this PR? |
|
I'm getting "No such file" error now |
|
.cat is returning two files for a directory? |
|
@diasdavid the exporter is exporting the dir, and apparently cat is using that export stream, so it has to filter based on path. The problem I see here is that the @alanshaw could you tell me the API call are you doing to trigger this cat? |
|
It's a direct call to js-ipfs in the browser - |
|
Directories now display so \o/ I'm so sorry @pgte but this change may have caused an issue elsewhere...listings for nested directories (using Expected (using go-ipfs):
Actual (using js-ipfs):
I'll check now if this was an existing bug or not and report back. |
* fix: cat: test file existence *after* filtering. Should fix #1142 * fix: cat: filtering out result files * fix: cat: for when the ipfs path is a buffer * fix: cat: remove /ipfs/ prefix if there is one
Should fix #1142