Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

feat: add cid command #1560

Merged
merged 3 commits into from
Oct 17, 2018
Merged

feat: add cid command #1560

merged 3 commits into from
Oct 17, 2018

Conversation

alanshaw
Copy link
Member

This PR adds a jsipfs cid command with tools for formatting, converting and discovering properties of CIDs.

All the docs are here: https://github.com/ipfs-shipyard/js-cid-tool
Will resolve this for JS: ipfs/kubo#5229
go-ipfs counterpart: ipfs/kubo#5385

@alanshaw alanshaw requested a review from daviddias September 13, 2018 16:04
@ghost ghost assigned alanshaw Sep 13, 2018
@ghost ghost added the status/in-progress In progress label Sep 13, 2018
Alan Shaw added 3 commits October 16, 2018 08:42
This PR adds a `jsipfs cid` command with tools for formatting, converting and discovering properties of CIDs.

All the docs are here: https://github.com/ipfs-shipyard/js-cid-tool
Will resolve this for JS: ipfs/kubo#5229
go-ipfs counterpart: ipfs/kubo#5385

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@alanshaw
Copy link
Member Author

@diasdavid ipfs/kubo#5385 has now been merged, it would be great to get your review and approval to get this in now 🙏


builder (yargs) {
return yargs
.commandDir(cidCommandsPath)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woa, this is magic. Running a CLI from another CLI ⚡️

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got the idea from js-ipfs-mfs ;)

@alanshaw alanshaw mentioned this pull request Oct 17, 2018
38 tasks
@alanshaw
Copy link
Member Author

Merging this as the test failure is because of ipfs.io DNS, unrelated to this PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants